unboundsoftware/schemas
6
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 32 Activity

feat(cache): add concurrency safety and logging improvements #635

Merged
argoyle merged 1 commits from feat/cache-concurrency-logging into main 2025-11-21 09:45:49 +00:00
Conversation 2 Commits 1 Files Changed 2
+487 -4
argoyle commented 2025-11-21 09:21:24 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Implement read-write mutex locks for cache functions to ensure
concurrency safety. Add debug logging for cache updates to enhance
traceability of operations. Optimize user addition logic to prevent
duplicates. Introduce a new test file for comprehensive cache
functionality testing, ensuring reliable behavior.

Implement read-write mutex locks for cache functions to ensure concurrency safety. Add debug logging for cache updates to enhance traceability of operations. Optimize user addition logic to prevent duplicates. Introduce a new test file for comprehensive cache functionality testing, ensuring reliable behavior.
argoyle (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2025-11-21 09:24:54 +00:00
argoyle commented 2025-11-21 09:40:37 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.94%. Comparing base (a1b0f49) to head (130e92d).

Files with missing lines Patch % Lines
cache/cache.go 91.17% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##            main     #631      +/-   ##
=========================================
+ Coverage   8.83%   13.94%   +5.11%     
=========================================
  Files         44       44              
  Lines       2344     2374      +30     
=========================================
+ Hits         207      331     +124     
+ Misses      2129     2034      -95     
- Partials       8        9       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
## [Codecov](https://app.codecov.io/gl/unboundsoftware/schemas/pull/631?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) Report :x: Patch coverage is `91.17647%` with `3 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 13.94%. Comparing base ([`a1b0f49`](https://app.codecov.io/gl/unboundsoftware/schemas/commit/a1b0f49aaba3ab174fbbd662e86c1a2a3f8d6ff5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware)) to head ([`130e92d`](https://app.codecov.io/gl/unboundsoftware/schemas/commit/130e92dc5f84a0a398a8c3a4ef40b14fb44f2248?dropdown=coverage&el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware)). | [Files with missing lines](https://app.codecov.io/gl/unboundsoftware/schemas/pull/631?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | Patch % | Lines | |---|---|---| | [cache/cache.go](https://app.codecov.io/gl/unboundsoftware/schemas/pull/631?src=pr&el=tree&filepath=cache%2Fcache.go&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware#diff-Y2FjaGUvY2FjaGUuZ28=) | 91.17% | [3 Missing :warning: ](https://app.codecov.io/gl/unboundsoftware/schemas/pull/631?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #631 +/- ## ========================================= + Coverage 8.83% 13.94% +5.11% ========================================= Files 44 44 Lines 2344 2374 +30 ========================================= + Hits 207 331 +124 + Misses 2129 2034 -95 - Partials 8 9 +1 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gl/unboundsoftware/schemas/pull/631?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware). :loudspeaker: Have feedback on the report? [Share it here](https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
argoyle (Migrated from gitlab.com) merged commit 5dc5043d46 into main 2025-11-21 09:45:49 +00:00
argoyle commented 2025-11-21 09:45:50 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

mentioned in commit 5dc5043d46

mentioned in commit 5dc5043d46a6abf853ddb0c1bde2f09d988e27b7
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 docker
go
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acctest (Shiny Acctest) argoyle (Joakim Olsson) buildtools (Buildtools) kubernetes (Kubernetes) releaser (Unbound Releaser) renovate (Renovate Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unboundsoftware/schemas#635
Delete Branch "feat/cache-concurrency-logging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?