unboundsoftware/schemas
6
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 32 Activity

feat(service): implement graceful shutdown for HTTP server #440

Merged
argoyle merged 1 commits from update-http-server-shutdown-handling into main 2025-04-12 11:55:59 +00:00
Conversation 3 Commits 1 Files Changed 5
+124 -22
argoyle commented 2025-04-12 08:43:58 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Add a context with timeout to handle graceful shutdown of the HTTP
server. Update error handling during the server's close to include
context-aware shutdown. Ensure that the server properly logs only
non-closed errors when listening.

Add a context with timeout to handle graceful shutdown of the HTTP server. Update error handling during the server's close to include context-aware shutdown. Ensure that the server properly logs only non-closed errors when listening.
argoyle (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2025-04-12 08:44:04 +00:00
argoyle commented 2025-04-12 11:40:42 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

aborted the automatic merge because target branch was updated

aborted the automatic merge because target branch was updated
argoyle commented 2025-04-12 11:41:08 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 2 commits

  • 8e02bfb0 - 1 commit from branch main
  • aaa111dd - feat(service): implement graceful shutdown for HTTP server

Compare with previous version

added 2 commits <ul><li>8e02bfb0 - 1 commit from branch <code>main</code></li><li>aaa111dd - feat(service): implement graceful shutdown for HTTP server</li></ul> [Compare with previous version](/unboundsoftware/schemas/-/merge_requests/436/diffs?diff_id=1326133755&start_sha=7b6f232a7fe7638c3b0deb3d6eeb1e6b0c242cae)
argoyle (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2025-04-12 11:41:15 +00:00
argoyle commented 2025-04-12 11:50:15 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.

Project coverage is 1.04%. Comparing base (8e02bfb) to head (aaa111d).

Files with missing lines Patch % Lines
logging/log.go 0.00% 25 Missing ⚠️
logging/mocklogger.go 0.00% 24 Missing ⚠️
cmd/service/service.go 0.00% 15 Missing ⚠️
cache/cache.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #436      +/-   ##
========================================
- Coverage   1.07%   1.04%   -0.03%     
========================================
  Files         37      39       +2     
  Lines       1865    1905      +40     
========================================
  Hits          20      20              
- Misses      1845    1885      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
## [Codecov](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) Report Attention: Patch coverage is `0%` with `66 lines` in your changes missing coverage. Please review. > Project coverage is 1.04%. Comparing base [(`8e02bfb`)](https://app.codecov.io/gl/unboundsoftware/schemas/commit/8e02bfb0a2918c13390385bd56a3ccc2b1eb61fa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) to head [(`aaa111d`)](https://app.codecov.io/gl/unboundsoftware/schemas/commit/aaa111dd20d227e2753c89cf05af43b3835761c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware). | [Files with missing lines](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | Patch % | Lines | |---|---|---| | [logging/log.go](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&filepath=logging%2Flog.go&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware#diff-bG9nZ2luZy9sb2cuZ28=) | 0.00% | [25 Missing :warning: ](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | | [logging/mocklogger.go](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&filepath=logging%2Fmocklogger.go&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware#diff-bG9nZ2luZy9tb2NrbG9nZ2VyLmdv) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | | [cmd/service/service.go](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&filepath=cmd%2Fservice%2Fservice.go&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware#diff-Y21kL3NlcnZpY2Uvc2VydmljZS5nbw==) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | | [cache/cache.go](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&filepath=cache%2Fcache.go&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware#diff-Y2FjaGUvY2FjaGUuZ28=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #436 +/- ## ======================================== - Coverage 1.07% 1.04% -0.03% ======================================== Files 37 39 +2 Lines 1865 1905 +40 ======================================== Hits 20 20 - Misses 1845 1885 +40 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gl/unboundsoftware/schemas/pull/436?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware). :loudspeaker: Have feedback on the report? [Share it here](https://gitlab.com/codecov-open-source/codecov-user-feedback/-/issues/4). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
argoyle (Migrated from gitlab.com) canceled auto merging this pull request when all checks succeed 2025-04-12 11:55:29 +00:00
argoyle (Migrated from gitlab.com) merged commit into main 2025-04-12 11:55:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 docker
go
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acctest (Shiny Acctest) argoyle (Joakim Olsson) buildtools (Buildtools) kubernetes (Kubernetes) releaser (Unbound Releaser) renovate (Renovate Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unboundsoftware/schemas#440
Delete Branch "update-http-server-shutdown-handling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?