build(deps): [security] bump golang.org/x/net from 0.13.0 to 0.17.0 #84

2023-10-12T13:24:44Z

argoyle commented

2023-10-12 13:24:44 +00:00

(Migrated from gitlab.com)

Bumps golang.org/x/net from 0.13.0 to 0.17.0. This update includes a security fix.

Vulnerabilities fixed

HTTP/2 rapid reset can cause excessive work in net/http A malicious HTTP/2 client which rapidly creates requests and immediately resets them can cause excessive server resource consumption. While the total number of requests is bounded by the http2.Server.MaxConcurrentStreams setting, resetting an in-progress request allows the attacker to create a new request while the existing one is still executing.

With the fix applied, HTTP/2 servers now bound the number of simultaneously executing handler goroutines to the stream concurrency limit (MaxConcurrentStreams). New requests arriving when at the limit (which can only happen after the client has reset an existing, in-flight request) will be queued until a handler exits. If the request queue grows too large, the server will terminate the connection.

This issue is also fixed in golang.org/x/net/http2 for users manually configuring HTTP/2.

The default stream concurrency limit is 250 streams (requests) per HTTP/2 connection. This value may be adjusted using the golang.org/x/net/http2 package; see the Server.MaxConcurrentStreams setting and the ConfigureServer function.

Patched versions: 0.17.0 Affected versions: < 0.17.0

Commits

b225e7c http2: limit maximum handler goroutines to MaxConcurrentStreams
88194ad go.mod: update golang.org/x dependencies
2b60a61 quic: fix several bugs in flow control accounting
73d82ef quic: handle DATA_BLOCKED frames
5d5a036 quic: handle streams moving from the data queue to the meta queue
350aad2 quic: correctly extend peer's flow control window after MAX_DATA
21814e7 quic: validate connection id transport parameters
a600b35 quic: avoid redundant MAX_DATA updates
ea63359 http2: check stream body is present on read timeout
ddd8598 quic: version negotiation
Additional commits viewable in compare view

Dependabot commands

You can trigger Dependabot actions by commenting on this MR

$dependabot recreate will recreate this MR rewriting all the manual changes and resolving conflicts

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.13.0 to 0.17.0. **This update includes a security fix.** <details> <summary>Vulnerabilities fixed</summary> <blockquote> HTTP/2 rapid reset can cause excessive work in net/http A malicious HTTP/2 client which rapidly creates requests and immediately resets them can cause excessive server resource consumption. While the total number of requests is bounded by the http2.Server.MaxConcurrentStreams setting, resetting an in-progress request allows the attacker to create a new request while the existing one is still executing. With the fix applied, HTTP/2 servers now bound the number of simultaneously executing handler goroutines to the stream concurrency limit (MaxConcurrentStreams). New requests arriving when at the limit (which can only happen after the client has reset an existing, in-flight request) will be queued until a handler exits. If the request queue grows too large, the server will terminate the connection. This issue is also fixed in golang.org/x/net/http2 for users manually configuring HTTP/2. The default stream concurrency limit is 250 streams (requests) per HTTP/2 connection. This value may be adjusted using the golang.org/x/net/http2 package; see the Server.MaxConcurrentStreams setting and the ConfigureServer function. Patched versions: 0.17.0 Affected versions: < 0.17.0 </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/b225e7ca6dde1ef5a5ae5ce922861bda011cfabd"><code>b225e7c</code></a> http2: limit maximum handler goroutines to MaxConcurrentStreams</li> <li><a href="https://github.com/golang/net/commit/88194ad8ab44a02ea952c169883c3f57db6cf9f4"><code>88194ad</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/net/commit/2b60a61f1e4cf3a5ecded0bd7e77ea168289e6de"><code>2b60a61</code></a> quic: fix several bugs in flow control accounting</li> <li><a href="https://github.com/golang/net/commit/73d82efb96cacc0c378bc150b56675fc191894b9"><code>73d82ef</code></a> quic: handle DATA_BLOCKED frames</li> <li><a href="https://github.com/golang/net/commit/5d5a036a503f8accd748f7453c0162115187be13"><code>5d5a036</code></a> quic: handle streams moving from the data queue to the meta queue</li> <li><a href="https://github.com/golang/net/commit/350aad2603e57013fafb1a9e2089a382fe67dc80"><code>350aad2</code></a> quic: correctly extend peer's flow control window after MAX_DATA</li> <li><a href="https://github.com/golang/net/commit/21814e71db756f39b69fb1a3e06350fa555a79b1"><code>21814e7</code></a> quic: validate connection id transport parameters</li> <li><a href="https://github.com/golang/net/commit/a600b3518eed7a9a4e24380b4b249cb986d9b64d"><code>a600b35</code></a> quic: avoid redundant MAX_DATA updates</li> <li><a href="https://github.com/golang/net/commit/ea633599b58dc6a50d33c7f5438edfaa8bc313df"><code>ea63359</code></a> http2: check stream body is present on read timeout</li> <li><a href="https://github.com/golang/net/commit/ddd8598e5694aa5e966e44573a53e895f6fa5eb2"><code>ddd8598</code></a> quic: version negotiation</li> <li>Additional commits viewable in <a href="https://github.com/golang/net/compare/v0.13.0...v0.17.0">compare view</a></li> </ul> </details> --- <details> <summary>Dependabot commands</summary> You can trigger Dependabot actions by commenting on this MR - `$dependabot recreate` will recreate this MR rewriting all the manual changes and resolving conflicts </details>

argoyle commented

2023-10-12 13:36:24 +00:00

(Migrated from gitlab.com)

Codecov Report

Merging #80 (9f7c371) into main (311fcfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   68.70%   68.70%           
=======================================
  Files           4        4           
  Lines         147      147           
=======================================
  Hits          101      101           
  Misses         43       43           
  Partials        3        3

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

## [Codecov](https://app.codecov.io/gl/unboundsoftware/gitlab-cleanup-handler/pull/80?src=pr&el=h1&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) Report > Merging [#80](https://app.codecov.io/gl/unboundsoftware/gitlab-cleanup-handler/pull/80?src=pr&el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) (9f7c371) into [main](https://app.codecov.io/gl/unboundsoftware/gitlab-cleanup-handler/commit/311fcfe221ca867c37d6d80f1991788ead6cfcba?el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware) (311fcfe) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main #80 +/- ## ======================================= Coverage 68.70% 68.70% ======================================= Files 4 4 Lines 147 147 ======================================= Hits 101 101 Misses 43 43 Partials 3 3 ``` :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=unboundsoftware)

argoyle (Migrated from gitlab.com) merged commit into main

2023-10-12 15:05:01 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unboundsoftware/gitlab-cleanup-handler#84