unboundsoftware/default-request-adder
6
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 28 Activity

multi-architecture-dockerfile-updates #228

Manually merged
argoyle merged 2 commits from multi-architecture-dockerfile-updates into main 2026-01-19 10:09:44 +00:00
Conversation 2 Commits 2 Files Changed 1
+7 -4
peter commented 2026-01-19 07:28:53 +00:00
Collaborator
Copy Link
Copy Source

Add ARG directives for TARGETOS and TARGETARCH to enable multi-architecture support.
Modify the build command to use the specified target OS and architecture for more flexible and portable builds.
Ensure compatibility with different deployment environments

Add ARG directives for TARGETOS and TARGETARCH to enable multi-architecture support. Modify the build command to use the specified target OS and architecture for more flexible and portable builds. Ensure compatibility with different deployment environments
peter added 2 commits 2026-01-19 07:28:59 +00:00
build: support multi-architecture builds in Dockerfile 936cc80c8e 
Add ARG directives for TARGETOS and TARGETARCH to enable 
multi-architecture support. Modify the build command to 
use the specified target OS and architecture for more 
flexible and portable builds. Ensure compatibility 
with different deployment environments.
fix: standardize Dockerfile stage names to uppercase
default-request-adder / vulnerabilities (pull_request) Successful in 1m52s
Details
default-request-adder / test (pull_request) Successful in 3m29s
Details
default-request-adder / build (pull_request) Failing after 54m53s
Details
1112550f30 
Updates the Dockerfile to use uppercase for multi-stage build
definitions. This change enhances readability and maintains consistency
across the build stages, ensuring alignment with common best practices in
Dockerfile conventions.
argoyle requested changes 2026-01-19 07:30:46 +00:00
Dismissed
Dockerfile Outdated
@@ -15,3 +18,3 @@
RUN go tool cover -func=coverage.txt
RUN rm coverage.txt.tmp
RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -mod=readonly -o release/default-request-adder -ldflags '-w -s'
RUN iGOOS=${TARGETOS} GOARCH=${TARGETARCH} CGO_ENABLED=0 go build -mod=readonly -o release/default-request-adder -ldflags '-w -s'
argoyle commented 2026-01-19 07:30:40 +00:00
Owner
Copy Link
Copy Source

The initial i looks like a typo?

The initial `i` looks like a typo?
peter marked this conversation as resolved
peter force-pushed multi-architecture-dockerfile-updates from 1112550f30 to 9a089c8af7 2026-01-19 07:32:06 +00:00 Compare
argoyle approved these changes 2026-01-19 07:34:25 +00:00
argoyle manually merged commit 24ed80e146 into main 2026-01-19 10:09:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
argoyle
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 docker
go
security
Pull requests that address a security vulnerability
 severity:moderate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acctest (Shiny Acctest) argoyle (Joakim Olsson) buildtools (Buildtools) kubernetes (Kubernetes) peter releaser (Unbound Releaser) renovate (Renovate Bot)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unboundsoftware/default-request-adder#228
Delete Branch "multi-architecture-dockerfile-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?