unboundsoftware/default-request-adder
6
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 28 Activity

refactor: simplify namespace exclusion logic #191

Merged
argoyle merged 1 commits from refactor-simplify-namespace-exclusion into master 2025-10-01 08:42:20 +00:00
Conversation 3 Commits 1 Files Changed 1
+2 -6
argoyle commented 2025-10-01 08:38:18 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Replace the manual loop for checking excluded namespaces with
the built-in slices.Contains function. This change enhances
the readability and efficiency of the code, while also
allowing for wildcard matching in exclusion.

Replace the manual loop for checking excluded namespaces with the built-in slices.Contains function. This change enhances the readability and efficiency of the code, while also allowing for wildcard matching in exclusion.
sparetimecoder (Migrated from gitlab.com) approved these changes 2025-10-01 08:38:18 +00:00
argoyle commented 2025-10-01 08:38:32 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

added 2 commits

  • a7ce0a5b - 1 commit from branch master
  • 3623ede8 - refactor: simplify namespace exclusion logic

Compare with previous version

added 2 commits <ul><li>a7ce0a5b - 1 commit from branch <code>master</code></li><li>3623ede8 - refactor: simplify namespace exclusion logic</li></ul> [Compare with previous version](/unboundsoftware/default-request-adder/-/merge_requests/188/diffs?diff_id=1511991122&start_sha=e42f76019d1d0b81d30a24e368f3e8e9abf159f1)
sparetimecoder commented 2025-10-01 08:40:34 +00:00 (Migrated from gitlab.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
argoyle (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2025-10-01 08:40:41 +00:00
argoyle (Migrated from gitlab.com) merged commit into master 2025-10-01 08:42:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
sparetimecoder
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 docker
go
security
Pull requests that address a security vulnerability
 severity:moderate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acctest (Shiny Acctest) argoyle (Joakim Olsson) buildtools (Buildtools) kubernetes (Kubernetes) peter releaser (Unbound Releaser) renovate (Renovate Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unboundsoftware/default-request-adder#191
Delete Branch "refactor-simplify-namespace-exclusion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?