Handle error on listing limit ranges, update example deploy and readme

README.MD

@@ -1,4 +1,4 @@
 # Default-request-adder
 A small container which periodically (every 10s) checks for a LimitRange on all non-excluded namespaces named `extreme-request-defaults` and creates it using the configured memory settings if absent.
 
-See the example-dir for an example deployment-file.
+[Example deployment-file](example/deploy.yaml)

example/deploy.yaml

@@ -1,3 +1,40 @@
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: default-request-adder
+  namespace: kube-system
+---
+
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: default-request-adder
+  namespace: kube-system
+rules:
+  - apiGroups: [""]
+    resources: ["namespaces"]
+    verbs: ["list"]
+  - apiGroups: [""]
+    resources: ["limitranges"]
+    verbs: ["list","create"]
+
+---
+
+apiVersion: rbac.authorization.k8s.io/v1beta1
+kind: ClusterRoleBinding
+metadata:
+  name: default-request-adder
+  namespace: kube-system
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: default-request-adder
+subjects:
+  - kind: ServiceAccount
+    name: default-request-adder
+    namespace: kube-system
+---
+
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -20,6 +57,7 @@ spec:
       labels:
         app: default-request-adder
     spec:
+      serviceAccountName: default-request-adder
       containers:
         - name: default-request-adder
           resources:

main.go

@@ -54,18 +54,22 @@ func main() {
 	for {
 		namespaces, err := clientset.CoreV1().Namespaces().List(metav1.ListOptions{})
 		if err != nil {
-			panic(err.Error())
+			panic(err)
 		}
 
 		for _, ns := range namespaces.Items {
 			if !nsExcluded(ns.Name, excludedNS) {
 				log.Printf("Checking for LimitRange named extreme-request-defaults in namespace '%v'\n", ns.Name)
-				if limitRanges, err := clientset.CoreV1().LimitRanges(ns.Name).List(metav1.ListOptions{FieldSelector: "metadata.name=extreme-request-defaults"}); err == nil && len(limitRanges.Items) == 0 {
+				if limitRanges, err := clientset.CoreV1().LimitRanges(ns.Name).List(metav1.ListOptions{FieldSelector: "metadata.name=extreme-request-defaults"}); err != nil {
-					log.Printf("Trying to create LimitRange\n")
+					panic(err)
-					if _, err := clientset.CoreV1().LimitRanges(ns.Name).Create(&limitRange); err != nil {
+				} else {
-						log.Printf("Unable to create LimitRange in namespace '%v': Error: %v\n", ns.Name, err)
+					if len(limitRanges.Items) == 0 {
-					} else {
+						log.Printf("Trying to create LimitRange\n")
-						log.Printf("LimitRange extreme-request-defaults created in namespace '%v'\n", ns.Name)
+						if _, err := clientset.CoreV1().LimitRanges(ns.Name).Create(&limitRange); err != nil {
+							log.Printf("Unable to create LimitRange in namespace '%v': Error: %v\n", ns.Name, err)
+						} else {
+							log.Printf("LimitRange extreme-request-defaults created in namespace '%v'\n", ns.Name)
+						}
 					}
 				}
 			}