dancefinder/dancefinder-app
5
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases Activity

chore(deps): remove deprecated subscriptions-transport-ws #2922

Merged
argoyle merged 1 commits from chore/remove-subscriptions-transport-ws into main 2026-05-25 10:54:19 +00:00
Conversation 0 Commits 1 Files Changed 3
+4 -298
argoyle commented 2026-05-25 09:58:46 +00:00
Owner
Copy Link
Copy Source

Removes the deprecated subscriptions-transport-ws package (Renovate dependency dashboard #49).

The package is unmaintained and was only reachable through the Apollo WebSocketLink in app/plugins/apollo.ts. The schema has no Subscription type and no subscription operations are defined, so the ws split() branch was dead code.

  • Drop WebSocketLink, the split() routing, getMainDefinition, and wsUrl from app/plugins/apollo.ts
  • Remove the direct subscriptions-transport-ws dependency

Verified with npm run build (green) and eslint (clean).

Note: the package lingers in the lockfile as an optional peer dep of @apollo/client v3; it disappears with the Apollo Client v4 upgrade, which removes @apollo/client/link/ws entirely.

🤖 Generated with Claude Code

Removes the deprecated `subscriptions-transport-ws` package (Renovate dependency dashboard #49). The package is unmaintained and was only reachable through the Apollo `WebSocketLink` in `app/plugins/apollo.ts`. The schema has no `Subscription` type and no subscription operations are defined, so the ws `split()` branch was dead code. - Drop `WebSocketLink`, the `split()` routing, `getMainDefinition`, and `wsUrl` from `app/plugins/apollo.ts` - Remove the direct `subscriptions-transport-ws` dependency Verified with `npm run build` (green) and eslint (clean). Note: the package lingers in the lockfile as an optional peer dep of `@apollo/client` v3; it disappears with the Apollo Client v4 upgrade, which removes `@apollo/client/link/ws` entirely. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
argoyle scheduled this pull request to auto merge when all checks succeed 2026-05-25 09:59:45 +00:00
argoyle force-pushed chore/remove-subscriptions-transport-ws from 8c2ef575db to 42361b7aa0 2026-05-25 10:44:54 +00:00 Compare
argoyle added 1 commit 2026-05-25 10:51:43 +00:00
chore(deps): remove deprecated subscriptions-transport-ws
dancefinder-app / build (pull_request) Successful in 2m15s
Details
dancefinder-app / deploy-prod (pull_request) Has been skipped
Details
0029d8dbaf 
The package is no longer maintained and was only reachable via the
Apollo WebSocketLink in app/plugins/apollo.ts. No Subscription type
exists in the schema and no subscription operations are defined, so the
ws split branch was dead code. Drop WebSocketLink, the split() routing,
and the direct dependency.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
argoyle force-pushed chore/remove-subscriptions-transport-ws from 42361b7aa0 to 0029d8dbaf 2026-05-25 10:51:43 +00:00 Compare
argoyle merged commit adf0cc4ac6 into main 2026-05-25 10:54:18 +00:00
argoyle deleted branch chore/remove-subscriptions-transport-ws 2026-05-25 10:54:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
Pull requests that update a dependency file
 docker
javascript
security
Pull requests that address a security vulnerability
 severity:critical
severity:high
severity:low
severity:moderate
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
argoyle (Joakim Olsson) buildtools (Buildtools) kubernetes (Kubernetes) releaser (Unbound Releaser) renovate (Renovate Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dancefinder/dancefinder-app#2922
Delete Branch "chore/remove-subscriptions-transport-ws"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?